Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mapping to /host/lib from fluentd-gcp container. #60722

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Remove mapping to /host/lib from fluentd-gcp container. #60722

merged 1 commit into from
Mar 16, 2018

Conversation

filbranden
Copy link
Contributor

What this PR does / why we need it:

This mapping is no longer needed since fluentd-gcp v2.0.16, in which it started using a container image based on Debian Stretch, in which the systemd libraries already include support for all the supported
compression algorithms.

The /run.sh in the image no longer accesses /host/lib anyways, so let's stop mapping it here.

Related changes:

/assign @timstclair
/cc @crassirostris @bmoyles0117

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A

Special notes for your reviewer:
N/A

Release note:

NONE

@filbranden
Remove mapping to /host/lib from fluentd-gcp container.
cea4c98 
This mapping is no longer needed since fluentd-gcp v2.0.16, in which it
started using a container image based on Debian Stretch, in which the
systemd libraries already include support for all the supported
compression algorithms.

The /run.sh in the image no longer accesses /host/lib anyways, so let's
stop mapping it here.

Related changes:
- fluentd-gcp on GoogleCloudPlatform/k8s-stackdriver#101
- fluentd-es on GoogleCloudPlatform/google-fluentd#80
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2018
@k8s-ci-robot
Copy link
Contributor

@filbranden: GitHub didn't allow me to request PR reviews from the following users: bmoyles0117.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

This mapping is no longer needed since fluentd-gcp v2.0.16, in which it started using a container image based on Debian Stretch, in which the systemd libraries already include support for all the supported
compression algorithms.

The /run.sh in the image no longer accesses /host/lib anyways, so let's stop mapping it here.

Related changes:

/assign @timstclair
/cc @crassirostris @bmoyles0117

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A

Special notes for your reviewer:
N/A

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2018
@jdumars
Copy link
Member

jdumars commented Mar 2, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2018
@filbranden
Copy link
Contributor Author

/retest

Ping? This should be good to go, since we no longer depend on the host libraries from inside the fluentd containers...

Thanks!
Filipe

@crassirostris
Copy link

Looks good, thanks!

/approve no-issue
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, filbranden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2018
@filbranden
Copy link
Contributor Author

Submit Queue says "Milestone is for a future release and cannot be merged", but I don't see any milestone set... Can someone in test infra help please?

@crassirostris
Copy link

There's a codefreeze, nothing merged except for PRs aimed for 1.10

Actually, I do believe this should go in 1.10. It's a small cleanup in the GCE deployment, unrelated to the release per se and it will be cherry-picked otherwise anyways

@crassirostris crassirostris added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. status/approved-for-milestone labels Mar 16, 2018
@crassirostris crassirostris added this to the v1.10 milestone Mar 16, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@crassirostris @filbranden @timstclair

Pull Request Labels
  • sig/instrumentation: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7e06332 into kubernetes:master Mar 16, 2018
@filbranden
Copy link
Contributor Author

Awesome, thanks @crassirostris !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crassirostris crassirostris Awaiting requested review from crassirostris

Assignees

@crassirostris crassirostris

@timstclair timstclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@filbranden @k8s-ci-robot @jdumars @crassirostris @k8s-github-robot @timstclair